community: langkit dependency #21174
Merged
+172
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XS
ccurme
approved these changes
May 6, 2024
dosubot
bot
added
the
lgtm
|
Hey team - going to revert this because it doesn't seem necessary for testing. We should only be adding optional + otherwise it just increases probability of dependency conflicts in the community lockfile. |
efriis
added a commit
that referenced
this pull request
May 6, 2024
Reverts #21174 Hey team - going to revert this because it doesn't seem necessary for testing. We should only be adding optional + extended_testing dependencies for deps that have extended tests. otherwise it just increases probability of dependency conflicts in the community lockfile.
dglogo
pushed a commit
to dglogo/langchain
that referenced
this pull request
May 8, 2024
Issue: the `langkit` package is not presented in the `pyproject.toml` but it is a requirement for the `WhyLabsCallbackHandler` Change: added `langkit` --------- Co-authored-by: Chester Curme <[email protected]>
dglogo
pushed a commit
to dglogo/langchain
that referenced
this pull request
May 8, 2024
Reverts langchain-ai#21174 Hey team - going to revert this because it doesn't seem necessary for testing. We should only be adding optional + extended_testing dependencies for deps that have extended tests. otherwise it just increases probability of dependency conflicts in the community lockfile.
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 10, 2024
Issue: the `langkit` package is not presented in the `pyproject.toml` but it is a requirement for the `WhyLabsCallbackHandler` Change: added `langkit` --------- Co-authored-by: Chester Curme <[email protected]>
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 10, 2024
Reverts langchain-ai#21174 Hey team - going to revert this because it doesn't seem necessary for testing. We should only be adding optional + extended_testing dependencies for deps that have extended tests. otherwise it just increases probability of dependency conflicts in the community lockfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the
langkitpackage is not presented in thepyproject.tomlbut it is a requirement for theWhyLabsCallbackHandlerChange: added
langkit